Attempt to make codecov less important #1203
Conversation
Having it apply flags for different runtimes et al. I was mostly pointing out that it's useful to have this combined thing as long as Codecov integration isn't compromised. |
|
FWIW, it's good to still upload separate reports from jobs because they get different flags/contexts assigned that are usable in the web UI, similar to the contexts that coveragepy can include. |
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
|
This is is the codecov report for this PR I see extra context on the right in main, but seems a bit useless. what am i missing? |
|
@webknjaz what am i missing from the codecov report, the summed up report vs individual ^ (see comment above) |
The PR views are different and sometimes inaccurate in Codecov. I recommend always consulting the linked |
@kingbuzzman you're missing flags that can tell you exactly what environments covered each line. You should start setting them, though. |
| - name: Report coverage | ||
| - name: Prepare coverage file for upload | ||
| if: contains(matrix.name, 'coverage') | ||
| uses: codecov/codecov-action@v5 | ||
| run: mv .coverage coverage.${TOXENV} | ||
|
|
||
| - name: Upload temporary coverage artifact | ||
| if: contains(matrix.name, 'coverage') | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| fail_ci_if_error: true | ||
| files: ./coverage.xml | ||
| token: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
Here, it'd be good to compute flags based on the matrix and env, as follows: https://github.com/tox-dev/workflow/blob/208490c/.github/workflows/reusable-tox.yml#L433-L444
There was a problem hiding this comment.
This is cool, i'm playing with it now, thanks!
| path: htmlcov | ||
| retention-days: ${{ steps.determine-retention-days.outputs.retention_days }} | ||
|
|
||
| - name: Delete temporary coverage artifacts from run |
There was a problem hiding this comment.
This isn't really that necessary, as you already set them to expire in one day. Plus, it'd be impossible to inspect these files whenever you suspect something's wrong.
There was a problem hiding this comment.
True. But its just noise, i figure i'd leave it "clean" -- but you're not wrong.
There was a problem hiding this comment.
It's just that I've recently seen a DIY implementation of this causing CI stability issues due to GH API or network being flaky and causing chaos. That memory is still fresh :)
But also, these are about inspectability.
If you want fewer artifacts, you can run actions/upload-artifact/merge and it'll do the deletion for you, replacing these with one artifact containing all the individual files.
There was a problem hiding this comment.
Now that i like! Thanks!
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Depends on #1202
Related to #1201 -- had to close it due to CI not running
This all started because yesterday codecov was having issues, and p!$#ed me off...
This PR aims to reduce the emphasis on Codecov by adjusting coverage exclusions in pyproject.toml and modifying the CI workflow to handle coverage reporting differently.
Revise the CI workflow to use ubuntu-latest, update Tox versions, and introduce dedicated coverage reporting and artifact handling steps.Miscellaneous:
CI now runs on all branches -- instead of those that were pointing tomainonlyUpdated tox version since python 3.8 is gone!